Skip to content

Conversation

LuchoBecerra
Copy link
Contributor

Listening port can be changed at runtime

@codecov-io
Copy link

Current coverage is 27.80% (diff: 100%)

Merging #2716 into master will not change coverage

@@             master      #2716   diff @@
==========================================
  Files            20         20          
  Lines          3625       3625          
  Methods         335        335          
  Messages          0          0          
  Branches        656        656          
==========================================
  Hits           1008       1008          
  Misses         2441       2441          
  Partials        176        176          

Powered by Codecov. Last update 7b32e6a...d9200eb

Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid having two duplicate chunks of code (in begin() and begin(port), please modify begin() implementation to call begin(_port);

@@ -82,6 +82,34 @@ void WiFiServer::begin() {
tcp_arg(listen_pcb, (void*) this);
}

void WiFiServer::begin(uint16_t port) {
close();
_port = port;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something happened with indentation on this line.

@devyte
Copy link
Collaborator

devyte commented Jan 10, 2018

Closing in favor of #4123

@devyte devyte closed this Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants